[Openvpn-devel] [M] Change in openvpn[master]: Replace SHA256 with SIPHASH24 in HMAC cookie approach
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 18:41:44 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <d3d352e8c9b78c10aec99bf870c41d77a162edbc-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============1592899573376197158== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="/TWLMLH0VN8="; charset=UTF-8 --/TWLMLH0VN8= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1827?usp=3Demail ) Change subject: Replace SHA256 with SIPHASH24= in HMAC cookie approach =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E Patch Set 3: Code-Review-1 (1 comment) File src/openvpn/in= it=2Ec: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827/comment/01bfb3d3_3b= 356a6a?usp=3Demail : PS3, Line 3476: ASSERT(rand_bytes(c->c2=2Esess= ion_id_key, sizeof(c->c2=2Esession_id_key))); I have to say that I don't pa= rticularly care for sprinkling that `ASSERT(rand_bytes())` all over the cod= e=2E Might be better to have a `siphash_key_init` or something=2E It will n= ot reduce the amount of code, but it will reduce the amount of duplicated s= emantics if you know what I mean=2E -- To view, visit http://gerrit=2Eo= penvpn=2Enet/c/openvpn/+/1827?usp=3Demail To unsubscribe, or for help writi= ng mail filters, visit http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail = Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master G= errit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3 Gerrit-Change-Nu= mber: 1827 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-openvpn@rfc2549= =2Eorg> Gerrit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> Gerrit-CC: = openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> Gerrit-Attention: p= laisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Comment-Date: Thu, 30 Jul 2026= 18:41:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --/TWLMLH0VN8= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 3:<span style=3D"borde= r-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgroun= d-color: #ffd4d4;">Code-Review -1</span></p><p><a href=3D"http://gerrit=2Eo= penvpn=2Enet/c/openvpn/+/1827?usp=3Demail">View Change</a></p><p>1 comment:= </p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad= ding: 0;"><p>File src/openvpn/init=2Ec:</p><ul style=3D"list-style: none; p= adding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margi= n-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827/c= omment/01bfb3d3_3b356a6a?usp=3Demail">Patch Set #3, Line 3476:</a> <code st= yle=3D"font-family:monospace,monospace"> ASSERT(rand_bytes(c->c2= =2Esession_id_key, sizeof(c->c2=2Esession_id_key)));</code></p><p class= =3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;">I have = to say that I don't particularly care for sprinkling that `ASSERT(rand_= bytes())` all over the code=2E Might be better to have a<br>`siphash_key_in= it` or something=2E It will not reduce the amount of code, but it will redu= ce the amount of duplicated semantics if you know what I mean=2E</p></li></= ul></li></ul><p>To view, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/o= penvpn/+/1827?usp=3Demail">change 1827</a>=2E To unsubscribe, or for help w= riting mail filters, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/setting= s?usp=3Demail">settings</a>=2E</p><div itemscope itemtype=3D"http://schema= =2Eorg/EmailMessage"><div itemscope itemprop=3D"action" itemtype=3D"http://= schema=2Eorg/ViewAction"><link itemprop=3D"url" href=3D"http://gerrit=2Eope= nvpn=2Enet/c/openvpn/+/1827?usp=3Demail"/><meta itemprop=3D"name" content= =3D"View Change"/></div></div> <div style=3D"display:none"> Gerrit-Message= Type: comment </div> <div style=3D"display:none"> Gerrit-Project: openvpn <= /div> <div style=3D"display:none"> Gerrit-Branch: master </div> <div style= =3D"display:none"> Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6= fc3 </div> <div style=3D"display:none"> Gerrit-Change-Number: 1827 </div> <= div style=3D"display:none"> Gerrit-PatchSet: 3 </div> <div style=3D"display= :none"> Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> <= div style=3D"display:none"> Gerrit-Reviewer: flichtenheld <frank@lichten= held=2Ecom> </div> <div style=3D"display:none"> Gerrit-CC: openvpn-devel= <openvpn-devel@lists=2Esourceforge=2Enet> </div> <div style=3D"displ= ay:none"> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> </= div> <div style=3D"display:none"> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:= 41:44 +0000 </div> <div style=3D"display:none"> Gerrit-HasComments: Yes </d= iv> <div style=3D"display:none"> Gerrit-Has-Labels: Yes </div> </body></ht= ml> --/TWLMLH0VN8=-- --===============1592899573376197158== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1592899573376197158== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============1592899573376197158==--