[Openvpn-devel] [S] Change in openvpn[master]: Replace ASSERT(rand_bytes(...)) with prng_bytes

Attention is currently required from: plaisthos.

cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1833?usp=email )

Change subject: Replace ASSERT(rand_bytes(...)) with prng_bytes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
In general, I think this is a good change.  It's incomplete, though, "git grep" says... after applying, I still have two occurances

```
src/openvpn/crypto.c:    ASSERT(rand_bytes(output, len));
src/openvpn/ssl_pkt.c:    ASSERT(rand_bytes(key, sizeof(key)));
```

so I think it makes sense to change those two as well?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1833?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If458a3362e03630ce699bd122e957169601657a5
Gerrit-Change-Number: 1833
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 09:29:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel