[Openvpn-devel] [S] Change in openvpn[master]: Replace ASSERT(rand_bytes(...)) with prng_bytes

Attention is currently required from: cron2.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1833?usp=email )

Change subject: Replace ASSERT(rand_bytes(...)) with prng_bytes
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> In general, I think this is a good change.  It's incomplete, though, "git grep" says... […]
The first one is prng_bytes itself:

void
prng_bytes(uint8_t *output, int len)
{
    ASSERT(rand_bytes(output, len));
}

The second one is something we could do but https://gerrit.openvpn.net/c/openvpn/+/1827 will then conflict since it completely removes the session_id_hmac_init method. I can do that if required but it might be worth the conflict. Or we merge 1827 first, then this one does not matter anyone because it is already gone.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1833?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If458a3362e03630ce699bd122e957169601657a5
Gerrit-Change-Number: 1833
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 10:39:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel