[Openvpn-devel] [M] Change in openvpn[master]: Rename variables that shadow other variables or functions

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email )

Change subject: Rename variables that shadow other variables or functions
......................................................................


Patch Set 13:

(2 comments)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/89261cd5_3a939032?usp=email :
PS13, Line 3670:             struct dns_domain *new = *entry;
Ouch! It might be a good idea to have an official guideline to not use C++ keywords as variable names, so we won't have to do special macro tricks if we need to `#include` OpenVPN C code in C++ code.


File src/openvpn/ps.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/76b9fc9f_6e56ef87?usp=email :
PS13, Line 878:             msg(M_ERR, "PORT SHARE: unexpected init recv_control status=%d", status);
But now we are probably printing the wrong `status` variable here. A change like this needs to carefully check if removing the shadow warning doesn't make subsequent code wrongly reference the "parent" variable.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I528f5fd200d877841e473e5e05b7ac7915fa2e33
Gerrit-Change-Number: 1618
Gerrit-PatchSet: 13
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 14 Aug 2026 12:34:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel