[Openvpn-devel] [M] Change in openvpn[master]: Rename variables that shadow other variables or functions

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email )

Change subject: Rename variables that shadow other variables or functions
......................................................................


Patch Set 13:

(2 comments)

File tests/unit_tests/openvpn/test_dhcp.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/8c28ed03_34fae63e?usp=email :
PS13, Line 58:     struct buffer clean_buf = alloc_buf_gc(512, &gc);
clear_buf vs. clean_buf is slightly pushing it for mishaps I think? 😊


File tests/unit_tests/openvpn/test_push_update_msg.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/45a8658f_1443ba3e?usp=email :
PS13, Line 347:     const char *cmsg1 = "PUSH_UPDATE, route 10.1.0.0 255.255.0.0, route 10.2.0.0 255.255.0.0, route 10.3.0.0 255.255.0.0,push-continuation 2";
Maybe push_msg1 here (and the same strategy below)? Would it make it a bit clearer?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I528f5fd200d877841e473e5e05b7ac7915fa2e33
Gerrit-Change-Number: 1618
Gerrit-PatchSet: 13
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 14 Aug 2026 12:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel