[Openvpn-devel] [M] Change in openvpn[master]: Reduce number of future epoch keys from 16 to 4

Attention is currently required from: plaisthos.

razvanc has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1844?usp=email )

Change subject: Reduce number of future epoch keys from 16 to 4
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
Is this a squash gone wrong? The patch does a lot more than the stated commit message, and the part where it does more doesn't build.


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1844/comment/f2a53ae7_00e7b2f9?usp=email :
PS1, Line 2000:                 buf_printf(&out, "P=%d\n", session->opt->ping_rec_timeout);
This actually does not build:

ssl.c: In function ‘push_peer_info’:
ssl.c:1998:31: error: ‘struct tls_options’ has no member named ‘ping_rec_timeout’; did you mean ‘packet_timeout’?
 1998 |             if (session->opt->ping_rec_timeout)
      |                               ^~~~~~~~~~~~~~~~
      |                               packet_timeout
ssl.c:2000:58: error: ‘struct tls_options’ has no member named ‘ping_rec_timeout’; did you mean ‘packet_timeout’?
 2000 |                 buf_printf(&out, "P=%d\n", session->opt->ping_rec_timeout);
      |                                                          ^~~~~~~~~~~~~~~~
      |                                                          packet_timeout



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1844?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id3c6681b29026c2920a62a0ea570fd098649e197
Gerrit-Change-Number: 1844
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 10:08:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel