[Openvpn-devel] [M] Change in openvpn[master]: Make required action returned from pre_decrypt_verdict more explicit

Attention is currently required from: flichtenheld, plaisthos, stipa.

razvanc has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email )

Change subject: Make required action returned from pre_decrypt_verdict more explicit
......................................................................


Patch Set 8:

(4 comments)

Patchset:

PS8: 
Just a few minor-ish comments. 😊


Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1826/comment/790ac71f_74691884?usp=email :
PS8, Line 10: is defined to decided if session_skip_to_pre_start should be used.
Typo: "to decide".


File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1826/comment/7b4c0a0a_8072e62c?usp=email :
PS8, Line 282:                  * state is using the same */
This comment now appears to be stale.


http://gerrit.openvpn.net/c/openvpn/+/1826/comment/cd87a5b4_c13c3108?usp=email :
PS8, Line 283:                 if (session_id_defined((&state.peer_session_id)))
Is it possible for this check to be false here?

It's possible that I'm missing something, but I _think_ tls_pre_decrypt_lite() is supposed to have run before we're here, and it rejects packets with no defined peer id.

If true, we can just remove this test and do something like:

    if (verdict == PRE_DECRYPT_CREATE_SESSION_SKIP)
    {
        ASSERT(session_id_defined(&state.peer_session_id));
    
        mi->context.c2.tls_multi->n_sessions++;
        struct tls_session *session = &mi->context.c2.tls_multi->session[TM_INITIAL];
        session_skip_to_pre_start(session, &state, &m->top.c2.from);
    }



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iccdd4cfad090c565aac27e16cdaa9871106c2f89
Gerrit-Change-Number: 1826
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: stipa <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 10:34:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel