Re: [PATCH v4 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60
Krzysztof Kozlowski <[email protected]> Tue, 9 Jun 2026 09:04:52 +0200
| Newsgroups | org.alsa-project.alsa-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <20260609-hysterical-rhino-of-resistance-d7e1da@quoll> |
On Tue, Jun 09, 2026 at 10:41:27AM +0800, Neo Chang wrote: > Add device tree bindings documentation for the Nuvoton NAU83G60 > audio amplifier. > > Signed-off-by: Neo Chang <[email protected]> > --- > Changes in v4: > - Refine the `firmware-name` description to clarify the loading order > (Left then Right) and the PBTL mode behavior. > - Remove the "dsp bypass" option description. > - Update the example node to follow devicetree coding styles. > > Changes in v3: > - Remove colon to resolve YAML build warnings. > - Fix 'firmware-name' property definition to comply with binding schemas > > Changes in v2: > - Dropped the word "driver" from the description. > - Removed runtime/software configuration properties: > nuvoton,low-latency, nuvoton,anc-enable, nuvoton,aec-enable, > nuvoton,vbat-microvolt, and nuvoton,tdm-channel-length. > - Added missing "nuvoton,dac-cur-enable" property for static speaker impedance matching. > - Removed unnecessary '|' formatting from single-line descriptions. > - Fixed typo in firmware-name property. > --- > .../bindings/sound/nuvoton,nau8360.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml > new file mode 100644 > index 000000000000..2d19aedf1419 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nuvoton,nau8360.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton NAU83G60 Stereo Class-D Amplifier with DSP > + > +description: > + Stereo Class-D Amplifier with DSP and I/V-sense. > + This device supports I2C. > + > +maintainers: > + - Neo Chang <[email protected]> > + > +properties: > + compatible: > + enum: > + - nuvoton,nau8360 > + > + reg: > + maxItems: 1 > + description: You want | Or this could be just enum of addresses, no need to copy paste address decoding from datasheet. > + The I2C address of the device. The address is determined by the external > + hardware configuration of GPIO1 and GPIO2 pins. > + - 0x1a (GPIO2=Low, GPIO1=Low) > + - 0x1b (GPIO2=Low, GPIO1=High) > + - 0x4a (GPIO2=High, GPIO1=Low) > + - 0x4b (GPIO2=High, GPIO1=High) > + > + "#sound-dai-cells": > + const: 0 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: mclk > + > + firmware-name: > + minItems: 2 > + maxItems: 2 > + description: > + Assign firmware filenames for Left and Right DSP cores. > + The first firmware is for the Left channel, > + and the second is for the Right channel. Drop all above and just list the items with description > + In PBTL mode, the Left firmware is ignored and only the Right is applied. Combining also this. items: - description: ... - description: ... Best regards, Krzysztof