RE: [PATCH 2/7] ASoC: codecs: ES8389: Fix the issue about mclk_src

Zhang Yi <[email protected]> Mon, 15 Jun 2026 14:06:54 +0800
Newsgroups org.alsa-project.alsa-devel,org.kernel.vger.linux-devicetree
Message-ID <[email protected]>
> > 
> >>>  	struct es8389_private *es8389 = snd_soc_component_get_drvdata(component);
> >>>  
> >>> -	ret = device_property_read_u8(component->dev, "everest,mclk-src", &es8389->mclk_src);
> >>
> >> Why are you changing implemented ABI?
> > 
> > In the old ABI, `mclk_src` was defined as `u8`, which meant that users could set `mclk_src` to any value in the DTS¡ªsuch as `0x02`,
> > but the code wouldn't recognize what that value represented.
> > The actual purpose of `mclk_src` is to indicate whether `sclk` should be used as `mclk`.
> > So I've changed it to bool.
> 
> You break ABI implemented by this driver, so you must clearly document
> it with reasons, why breaking is necessary. Honestly, without proper
> reason I would just answer that you must keep it backwards compatible.

OK