RE: [PATCH 7/7] ASoC: dt-bindings: ES8389: Add members about HPF and clock
Zhang Yi <[email protected]> Mon, 15 Jun 2026 14:07:44 +0800
| Newsgroups | org.alsa-project.alsa-devel,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
> >>> + $ref: /schemas/types.yaml#/definitions/flag > >>> + description: > >>> + Indicates that SCLK is used as the internal clock. > >> > >> And what happens with mclk in such case? Is it still wired? > > > > Yes, setting mclk-from-sclk does not affect the MCLK connection. > > I am asking about wiring of the device. If MCLK is used from SCLK, but > SCLK is used as the internal clock, then how can you still have MCLK > connected? If MCLK is derived from SCLK, whether the 'MCLK' pin on the device is connected or not has no effect on operation. > >>> + > >>> + everest,hpfl: > >>> + $ref: /schemas/types.yaml#/definitions/uint8 > >>> + description: > >>> + the HPF value of ADCL. > >> > >> Is HPF value in dB? If so, use proper unit suffix and proper units. > > > > No, the values here correspond to the values in the registers. > > The value is not in dB > > What are the meanings of the register values? The value of everest,hpfl is equal to the value of the corresponding register, not the cutoff frequency of the HPF. The code does not specify which register corresponds to which HPF cutoff frequency. And we did not set the HPF to kcontrol because we do not want users to be able to control it while the codec is running. > >>> + everest,hpfl = [0a]; > >> > >> <0xa>? What did you want to say here? > > > > I just wanted to give an example to show how to set the values of everest,hpfl to 0x0a. > > So use syntax I asked. OK If you receive this email, please reply to me. (I'm worried that the issue with not receiving emails might happen again.)