Re: [PATCH i-g-t] tools/xe-perf/xe-perf-recorder: don't write OA report multiple times

On 7/21/2026 6:02, Ashutosh Dixit wrote:
> Fix bug because of which a single report is written multiple times (rather
> than writing multiple reports).
>
> Signed-off-by: Ashutosh Dixit <[email protected]>

Patch seems correct, but since it's a bug fix, should we also include 
the <sha> commit-details in the commit message as a "Fixes <sha> 
commit-details..."?

That's your call, but other than that,

Reviewed-by: Shekhar Chauhan <[email protected]>

> ---
>   tools/xe-perf/xe_perf_recorder.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tools/xe-perf/xe_perf_recorder.c b/tools/xe-perf/xe_perf_recorder.c
> index f200fe9c9b..61c3f6945c 100644
> --- a/tools/xe-perf/xe_perf_recorder.c
> +++ b/tools/xe-perf/xe_perf_recorder.c
> @@ -587,6 +587,8 @@ static bool write_stream_data(struct recording_context *ctx,
>   
>   		if (fwrite(data, format_size, 1, output) != 1)
>   			return false;
> +
> +		data += format_size;
>   	}
>   
>   	return true;

-- 
Shekhar Chauhan
Linux Graphics Software Engineer
Intel Corporation