Re: [PATCH i-g-t v2] tests/intel/xe_pxp: Require output for display tests

On 7/21/2026 8:31 AM, Jonathan Cavitt wrote:
> The subtests display-pxp-fb and display-black-pxp-fb both call the
> function igt_create_color_fb with a width and height value generated by
> getting outputs from for_each_connected_output and selecting the maximum
> width and height among all available connected outputs.  If there are no
> such outputs, then the resulting values will be zero, which is an invalid
> input for the DRM_IOCLT_MODE_CREATE_DUMB ioctl.
>
> Skip these tests if there are no connected outputs.
>
> v2:
> - Use correct ioctl name (jcavitt)
> - Add missing closes tag (jcavitt)
> - Use igt_display_require_output in require_display instead (Daniele)
>
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/work_items/7738
> Signed-off-by: Jonathan Cavitt <[email protected]>
> Cc: Daniele Ceraolo Spurio <[email protected]>
> Cc: Ville Syrjälä <[email protected]>

Reviewed-by: Daniele Ceraolo Spurio <[email protected]>

Daniele

> ---
>   tests/intel/xe_pxp.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel/xe_pxp.c b/tests/intel/xe_pxp.c
> index 9320078733..5460bf6db1 100644
> --- a/tests/intel/xe_pxp.c
> +++ b/tests/intel/xe_pxp.c
> @@ -1002,6 +1002,7 @@ static void require_display(int xe_fd, igt_display_t *display)
>   {
>   	igt_require_pipe_crc(xe_fd);
>   	igt_display_require(display, xe_fd);
> +	igt_display_require_output(display);
>   }
>   
>   static void dpms_on_off(int fd, drmModeResPtr res, int mode)