Re: [PATCH i-g-t 2/2] tests/kms_properties: set client cap for color pipeline

On 7/22/2026 3:42 PM, Kamil Konieczny wrote:
> Hi Chaitanya,
> On 2026-07-14 at 20:15:32 +0530, Chaitanya Kumar Borah wrote:
>> Set DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE for colorop subtests.
>> Unset it when done.
> 
> As you change this test could you (or someone from cc list?) look
> and help with review a series here:
> 
> https://patchwork.freedesktop.org/series/167775/
> test/kms_colorop_helper: don't request colorop updates indefinitely
> 

Sure Kamil, I will bump it up my TODO list.

==
Chaitanya

> Thanks in advance!
> 
> Regards,
> Kamil
> 
> PS. adding to cc Melissa Wen <[email protected]>
> 
>>
>> Cc: John Harrison <[email protected]>
>> Cc: Kamil Konieczny <[email protected]>
>> Cc: Swati Sharma <[email protected]>
>> Cc: Harry Wentland <[email protected]>
>> Signed-off-by: Chaitanya Kumar Borah <[email protected]>
>> ---
>>   tests/kms_properties.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
>> index f735839da..93bf1ea26 100644
>> --- a/tests/kms_properties.c
>> +++ b/tests/kms_properties.c
>> @@ -340,10 +340,18 @@ static void colorop_properties(igt_display_t *display, bool atomic)
>>   	bool found_any = false, found;
>>   	igt_output_t *output;
>>   	igt_crtc_t *crtc;
>> +	int ret;
>>   
>>   	/* colorops are only available with atomic */
>>   	igt_skip_on(!display->is_atomic);
>>   
>> +	ret = drmSetClientCap(display->drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1);
>> +	igt_skip_on_f(ret, "DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE not supported\n");
>> +
>> +	igt_display_fini(display);
>> +	igt_display_require(display, display->drm_fd);
>> +	display->has_plane_color_pipeline = true;
>> +
>>   	for_each_crtc(display, crtc) {
>>   		found = false;
>>   
>> @@ -369,6 +377,12 @@ static void colorop_properties(igt_display_t *display, bool atomic)
>>   		}
>>   	}
>>   
>> +	ret = drmSetClientCap(display->drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 0);
>> +	igt_assert_eq(ret, 0);
>> +
>> +	igt_display_fini(display);
>> +	igt_display_require(display, display->drm_fd);
>> +
>>   	igt_skip_on(!found_any);
>>   }
>>   
>> -- 
>> 2.25.1
>>