Re: [PATCH i-g-t v1 06/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack`

On 13-07-2026 02:25 pm, Michał Grzelak wrote:
> igt@kms_frontbuffer_tracking uses TEST_MODE_ITER_BEGIN(t) which consists
> of nested for loops. However many loops can be omitted due to continue
> statements. This obfuscates following the execution of any given
> codepath. Replace TEST_MODE_ITER_BEGIN(t) for fliptrack tests with macro
> definition and remove loops that are skipped.
>
> Signed-off-by: Michał Grzelak <[email protected]>
> ---
>   tests/intel/kms_frontbuffer_tracking.c | 24 ++++++++++++++++++------
>   1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index f5c2a81434..c41f97bd34 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -4511,11 +4511,21 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
>   			}
>   	TEST_MODE_ITER_END
>   
> -	TEST_MODE_ITER_BEGIN(t)
> -		if (t.plane != PLANE_PRI ||
> -		    t.screen != SCREEN_PRIM ||
> -		    t.method != IGT_DRAW_MMAP_GTT ||
> -		    (t.feature & FEATURE_FBC) == 0)
> +	t.format = FORMAT_DEFAULT;
> +	t.flip = FLIP_PAGEFLIP;
> +	t.tiling = opt.tiling;
> +	t.plane = PLANE_PRI;
> +	t.screen = SCREEN_PRIM;
> +	t.method = IGT_DRAW_MMAP_GTT;
> +
> +	for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
> +	for (t.pipes = 0; t.pipes < PIPE_COUNT; t.pipes++) {
> +	for (t.fbs = 0; t.fbs < FBS_COUNT; t.fbs++) {
NIT:  Nested for-loop opening braces sit at the same indentation level, 
Please correct indentation
> +		if (!opt.show_hidden && t.feature == FEATURE_NONE)
> +			continue;
> +		if ((t.feature & FEATURE_PSR) && (t.feature & FEATURE_DRRS))
> +			continue;
> +		if ((t.feature & FEATURE_FBC) == 0)
>   			continue;
>   
>   		igt_subtest_f("%s-%s-%s-fliptrack-%s",
> @@ -4527,7 +4537,9 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
>   			igt_require(igt_draw_supports_method(drm.fd, t.method));
>   			fliptrack_subtest(&t, FLIP_PAGEFLIP);
>   		}
> -	TEST_MODE_ITER_END
> +			}
> +		}
> +	}
>   
>   	TEST_MODE_ITER_BEGIN(t)
>   		if (t.screen == SCREEN_OFFSCREEN ||