Re: [PATCH v3 02/12] lib/igt_kms: Add IGT_COLOROP_FIXED_MATRIX property

On 2026-07-25 02:56, Alex Hung wrote:
> 
> 
> On 6/23/26 11:57, Harry Wentland wrote:
>> Add support for the Fixed Matrix colorop property:
>> - Add IGT_COLOROP_FIXED_MATRIX property to the colorop property enum
>>    and names array in igt_kms
>>
>> Assisted-by: Claude:claude-opus-4-6
>> Signed-off-by: Harry Wentland <[email protected]>
>> ---
>>   lib/igt_kms.c | 1 +
>>   lib/igt_kms.h | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index e82d32130666..9003b2b9e670 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -725,6 +725,7 @@ const char * const igt_colorop_prop_names[IGT_NUM_COLOROP_PROPS] = {
>>       [IGT_COLOROP_MULTIPLIER] = "MULTIPLIER",
>>       [IGT_COLOROP_LUT3D_INTERPOLATION] = "LUT3D_INTERPOLATION",
>>       [IGT_COLOROP_NEXT] = "NEXT",
>> +    [IGT_COLOROP_FIXED_MATRIX] = "FIXED_MATRIX_TYPE",
> Should we move IGT_COLOROP_FIXED_MATRIX before NEXT?
>>   };
>>     const char * const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
>> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
>> index 3df3ba86630e..1be58288e119 100644
>> --- a/lib/igt_kms.h
>> +++ b/lib/igt_kms.h
>> @@ -363,6 +363,7 @@ enum igt_atomic_colorop_properties {
>>       IGT_COLOROP_MULTIPLIER,
>>       IGT_COLOROP_LUT3D_INTERPOLATION,
>>       IGT_COLOROP_NEXT,
>> +    IGT_COLOROP_FIXED_MATRIX,
> Should we move IGT_COLOROP_FIXED_MATRIX before NEXT?

I would prefer not to re-order existing enum values and
simply append new ones. I see no good reason why _NEXT
should be the last entry of the enum.

Harry

>>       IGT_NUM_COLOROP_PROPS
>>   };
>>   
>