Re: [PATCH i-g-t 2/3] benchmarks/gem_wsim: fix ticks_delta assertion for non-inverted logic

Zbigniew Kempczyński <[email protected]> Fri, 31 Jul 2026 17:53:46 +0200
Newsgroups org.freedesktop.lists.igt-dev
Message-ID <mwfdzjk5kie7blngoan25f4kycsw5e74afvpi3yqz6pqtwvirp@hbpkdon3fh4t>
On Fri, Jul 31, 2026 at 04:18:05PM +0200, Marcin Bernatowicz wrote:
> xe_spin now stores elapsed ticks directly in ticks_delta (not inverted).
> Update the post-execution assertion accordingly.
> 

LGTM:

Reviewed-by: Zbigniew Kempczyński <[email protected]>

--
Zbigniew

> Signed-off-by: Marcin Bernatowicz <[email protected]>
> Cc: Adam Miszczak <[email protected]>
> Cc: Kamil Konieczny <[email protected]>
> Cc: Lukasz Laguna <[email protected]>
> Cc: Zbigniew Kempczyński <[email protected]>
> ---
>  benchmarks/gem_wsim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> index 8be44d0c8..462188708 100644
> --- a/benchmarks/gem_wsim.c
> +++ b/benchmarks/gem_wsim.c
> @@ -2676,7 +2676,7 @@ static void xe_w_step_sync_and_verify(struct w_step *w)
>  
>  	if (!w->duration.unbound) {
>  		igt_assert(w->duration.requested_ticks && w->xe.data->spin.ticks_delta);
> -		igt_assert_lte(w->duration.requested_ticks, ~w->xe.data->spin.ticks_delta);
> +		igt_assert_lte(w->duration.requested_ticks, w->xe.data->spin.ticks_delta);
>  	}
>  }
>  
> -- 
> 2.43.0
>