[PATCH i-g-t v3 0/6] test/kms_colorop_helper: don't request colorop updates indefinitely

After committing colorop settings, colorops are still flagged as
changed, even if there is no new request for updates. This v3 addresses
Chaitanya's comments [v2] to fix an extra space and split one commit
into three, as follows:

- Patch 1 clears colorop flag after commit so that the next patch
  doesn't try to re-submit changes on inactive color pipeline.

- Patch 2 prevents colorop to be marked as changed just because it was
  checking if a property enum value is supported. These changes are
  consistent with the current expetation of allowing property changes in
  colorop that are part of a current active color pipeline or a color
  pipeline that will be activated or deactived in the same atomic commit;
  but rejecting attempts to change inactive colorops.

- Patch 3 (new): was detached from previous-version patch 3 to only
  verify colorop properties in planes that support plane COLOR_PIPELINE
  property, i.e. planes that has a colorop pipeline, since not all planes
  have to support it.

- Patch 4 (new): was also detached from previous-version patch 3 and now
  it basically keeps a primary plane always active for a given CRTC,
  even though colorop properties of an overlay plane is under testing.

- Patch 5: is the main change of previous-version patch 3 that fixes
  kms_properties to match colorop update requirements of an active plane
  color pipeline.

- Patch 6 just ensure that kms_color_pipeline expects an intel device
  and will not run otherwise. As color validation works better with
  writeback then CRC, other devices should prefer kms_colorop if they have
  writeback support. If not, they should work on adapting
  kms_color_pipeline according to their specs.

[v1] https://lore.kernel.org/igt-dev/[email protected]/

Lemme know your thought!

Melissa

Melissa Wen (6):
  lib/igt_kms: clear colorop-changed flag after commit
  test/kms_colorop_helper: only check if a given enum value exist
  tests/kms_properties: don't check colorop if no plane color pipeline prop
  tests/kms_properties: keep primary plane enabled for each CRTC
  tests/kms_properties: check colorop properties on active color pipelines
  tests/kms_color_pipeline: skip if not an intel device

 lib/igt_kms.c              | 41 ++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h              |  4 ++++
 tests/kms_color_pipeline.c |  1 +
 tests/kms_colorop_helper.c |  4 +++-
 tests/kms_properties.c     | 26 ++++++++++++++++++++++--
 5 files changed, 73 insertions(+), 3 deletions(-)

-- 
2.53.0