[PATCH i-g-t v2] tests/kms_plane: Remove redundant CRC frame sequence check
Jason-JH Lin <[email protected]>
| Newsgroups | org.freedesktop.lists.igt-dev |
|---|---|
| Message-ID | <[email protected]> |
The capture_crc() function validated that the CRC frame sequence
returned by igt_pipe_crc_get_for_frame() matches the expected value.
However, igt_pipe_crc_get_for_frame() already guarantees
crc->frame >= expected via its internal loop:
do {
read_one_crc(pipe_crc, crc);
} while (igt_vblank_before(crc->frame, vblank));
The additional check in capture_crc() is therefore redundant.
Remove it and rely on the library's existing guarantee.
Signed-off-by: Jason-JH Lin <[email protected]>
---
tests/kms_plane.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 12dfbfe1d82b..fe8ee2ab26ab 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -765,11 +765,6 @@ static int num_unique_crcs(const igt_crc_t crc[], int num_crc)
static void capture_crc(data_t *data, unsigned int vblank, igt_crc_t *crc)
{
igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, vblank, crc);
-
- igt_fail_on_f(!igt_skip_crc_compare && !igt_run_in_simulation() &&
- crc->has_valid_frame && crc->frame != vblank,
- "Got CRC for the wrong frame (got %u, expected %u). CRC buffer overflow?\n",
- crc->frame, vblank);
}
static void capture_format_crcs_single(data_t *data, igt_crtc_t *crtc,
--
2.43.0