Re: [PATCH i-g-t v2] tests/kms_plane: Remove redundant CRC frame sequence check
Jason-JH Lin (林睿祥) <[email protected]>
| Newsgroups | org.freedesktop.lists.igt-dev |
|---|---|
| Message-ID | <[email protected]> |
> > diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> > index 12dfbfe1d82b..fe8ee2ab26ab 100644
> > --- a/tests/kms_plane.c
> > +++ b/tests/kms_plane.c
> > @@ -765,11 +765,6 @@ static int num_unique_crcs(const igt_crc_t
> > crc[], int num_crc)
> > static void capture_crc(data_t *data, unsigned int vblank,
> > igt_crc_t *crc)
> > {
> > igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
> > vblank, crc);
>
> Also if this is only igt_pipe_crc_get_for_frame now, ideally we can
> just
> remove this function itself and call the helper directly.
No problem.
> But before
> doing that, as the existing assert was added by a patch from Ville
> and
> rb'ed by JP, I'll request an ack from them or if they have any inputs
> on
> this.
>
That's great! Thank you for your help!
Regards,
Jason-JH Lin
> Regards,
> Karthik.B.S
> > -
> > - igt_fail_on_f(!igt_skip_crc_compare &&
> > !igt_run_in_simulation() &&
> > - crc->has_valid_frame && crc->frame !=
> > vblank,
> > - "Got CRC for the wrong frame (got %u,
> > expected %u). CRC buffer overflow?\n",
> > - crc->frame, vblank);
> > }
> >
> > static void capture_format_crcs_single(data_t *data, igt_crtc_t
> > *crtc,