[PATCH] unigraf: Use proper hardware API for HPD pulsing
Mark Yacoub <[email protected]>
| Newsgroups | org.freedesktop.lists.igt-dev |
|---|---|
| Message-ID | <[email protected]> |
With the latest Unigraf firmware, hardware HPD pulsing works reliably. Switch to using the `unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, ...)` API directly rather than circumventing it with manual assert/deassert time-based toggles. Signed-off-by: Mark Yacoub <[email protected]> --- lib/vendor/unigraf/unigraf.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/vendor/unigraf/unigraf.c b/lib/vendor/unigraf/unigraf.c index 30ee3c72b..627ec65b1 100644 --- a/lib/vendor/unigraf/unigraf.c +++ b/lib/vendor/unigraf/unigraf.c @@ -612,13 +612,7 @@ void unigraf_hpd_assert(void) */ void unigraf_hpd_pulse(int duration) { - /* In theory this should work: - * unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, duration); - * But this seems to be broken and this works: - */ - unigraf_hpd_deassert(); - usleep(duration); - unigraf_hpd_assert(); + unigraf_write_u32(TSI_DPRX_HPD_PULSE_W, duration); } /** -- 2.55.0.691.gc56d675ccc-goog