Re: [PATCH i-g-t v3 6/6] tests/kms_color_pipeline: skip if not an intel device

On 2026-08-17 11:39, Harry Wentland wrote:
> 
> 
> On 2026-08-17 11:19, Melissa Wen wrote:
>>
>>
>> On 14/08/2026 05:55, Alex Hung wrote:
>>>
>>>
>>> On 8/11/26 08:23, Melissa Wen wrote:
>>>>  From documentation, the test requires i915 or xe driver, so make sure it
>>>> only runs with intel devices. In addition, it's a CRC-based test, making
>>> Should this test be moved to tests/intel/?
>>
>> I kept it as a KMS test because kms_colorop relies on writeback support, but writeback isn't present in many drivers AFAIK.
>> So these CRC tests can be used by other drivers if they don't support writeback but support colorop.
>>
> 
> In that case the test shouldn't have an igt_require(is_intel_device...). It should
> use a generic check to determine whether it runs or not.
> 

Not a blocker, btw. I just would like to see less "is_intel_device" in "generic"
IGT tests.

Harry

> Harry
> 
>> Melissa
>>
>>>
>>>> kms_colorop with writeback more aligned with color testing and
>>>> validation. Other drivers should work on adapting this test to their
>>>> needs if they are looking for CRC validation.
>>>>
>>>> Reviewed-by: Chaitanya Kumar Borah <[email protected]>
>>>> Signed-off-by: Melissa Wen <[email protected]>
>>>> ---
>>>>   tests/kms_color_pipeline.c | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/tests/kms_color_pipeline.c b/tests/kms_color_pipeline.c
>>>> index 78860a845..3978745a5 100644
>>>> --- a/tests/kms_color_pipeline.c
>>>> +++ b/tests/kms_color_pipeline.c
>>>> @@ -372,6 +372,7 @@ int igt_main()
>>>>           igt_display_require(&data.display, data.drm_fd);
>>>>           data.display.has_plane_color_pipeline = has_plane_color_pipeline;
>>>>           igt_require(data.display.is_atomic);
>>>> +        igt_require(is_intel_device(data.drm_fd));
>>>>       }
>>>>         igt_subtest_group()
>>>
>>
>