Re: [PATCH i-g-t v2 07/16] tests/kms_pipe_crc_basic: limit #crtcs tested during suspend

On 08-08-2026 04:17 am, Michał Grzelak wrote:
> Limit execution of suspend tests to first and last active CRTC unless
> using `extended` flag. This helps with reducing default execution time
> of the test which can lower number of hitting CI timeout.
>
> v1->v2
> - move constraint before crtc_output_combo_valid() (Mohammed)
>
> Signed-off-by: Michał Grzelak<[email protected]>

LGTM:

Reviewed-by: Mohammed Thasleem <[email protected]>

> ---
>   tests/kms_pipe_crc_basic.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
> index 42e1415452..f1f89f11f8 100644
> --- a/tests/kms_pipe_crc_basic.c
> +++ b/tests/kms_pipe_crc_basic.c
> @@ -127,6 +127,16 @@ enum {
>   	TEST_HANG = 1 << 3,
>   };
>   
> +static bool suspend_constraint(unsigned flags, igt_crtc_t *crtc)
> +{
> +	if (!extended && (flags & TEST_SUSPEND) &&
> +	    crtc->crtc_index != active_crtcs[0] &&
> +	    crtc->crtc_index != active_crtcs[last_crtc_index])
> +		return true;
> +
> +	return false;
> +}
> +
>   static void test_read_crc(data_t *data, igt_crtc_t *crtc,
>   			  igt_output_t *output, unsigned flags)
>   {
> @@ -425,6 +435,9 @@ int igt_main_args("e", NULL, help_str, opt_handler, NULL)
>   				if (simulation_constraint(crtc))
>   					continue;
>   
> +				if (suspend_constraint(tests[i].flags, crtc))
> +					continue;
> +
>   				if(!crtc_output_combo_valid(&data.display, crtc, output))
>   					continue;
>