Re: [PATCH i-g-t 6/6] tests/intel/xe_pmu: Disable VFs before restoring sched params

On 8/18/2026 14:39, Marcin Bernatowicz wrote:
> Restore scheduling defaults after VFs are disabled rather than while they
> are still active, matching the cleanup order already used by
> xe_sriov_scheduling. Resetting scheduling parameters of active VFs can
> leave cleanup incomplete and cause subsequent VF probing to fail.
>
> Assisted-by: Copilot:Claude-Opus-5
> Signed-off-by: Marcin Bernatowicz <[email protected]>
> Cc: Adam Miszczak <[email protected]>
> Cc: Jakub Kolakowski <[email protected]>
> Cc: Lukasz Laguna <[email protected]>

Reviewed-by: Lukasz Laguna <[email protected]>

> Cc: Michal Wajdeczko <[email protected]>
> ---
>   tests/intel/xe_pmu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
> index 2d1bc1f61..a8ceac46c 100644
> --- a/tests/intel/xe_pmu.c
> +++ b/tests/intel/xe_pmu.c
> @@ -1023,8 +1023,8 @@ static void unprovision_and_disable_vfs(int fd)
>   {
>   	int ret;
>   
> -	ret = __xe_sriov_admin_bulk_restore_sched_defaults(fd);
>   	xe_sriov_disable_vfs_restore_auto_provisioning(fd);
> +	ret = __xe_sriov_admin_bulk_restore_sched_defaults(fd);
>   	/* abort to avoid execution of next tests with enabled VFs */
>   	igt_abort_on_f(igt_sriov_get_enabled_vfs(fd) > 0,
>   		       "Failed to disable VF(s)");