Re: [PATCH v1 2/2] tests/intel/xe_exec_system_allocator: use correct DONTNEED test flag

Hi Nishit,
On 2026-08-19 at 14:53:01 +0000, [email protected] wrote:
> From: Nishit Sharma <[email protected]>
> 
> Test now using correct flag (USE_MADV_DONTNEED) instead of the libc
> MADV_DONTNEED constant. Both USE_MADV_DONTNEED and MADV_DONTNEED have
> value 4 and went unnoticable.
> 
> Signed-off-by: Nishit Sharma <[email protected]>
> ---
>  tests/intel/xe_exec_system_allocator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_exec_system_allocator.c b/tests/intel/xe_exec_system_allocator.c
> index 476470be7..305512dfd 100644
> --- a/tests/intel/xe_exec_system_allocator.c
> +++ b/tests/intel/xe_exec_system_allocator.c
> @@ -2337,7 +2337,7 @@ test_compute(int fd, struct drm_xe_engine_class_instance *eci, size_t size,
>  	xe_wait_ufence(fd, &bo_sync->sync, USER_FENCE_VALUE, 0, FIVE_SEC);
>  
>  	env.loop_count = (flags & TOUCH_ONCE) ? 1 : env.array_size;
> -	env.skip_results_check = !(flags & ACCESS_DEVICE_HOST) || (flags & MADV_DONTNEED);
> +	env.skip_results_check = !(flags & ACCESS_DEVICE_HOST) || (flags & USE_MADV_DONTNEED);

Good catch, maybe flags should have TEST_FLAG_ prefix?
LGTM
Reviewed-by: Kamil Konieczny <[email protected]>

Regards,
Kamil

>  	env.vm = vm;
>  
>  	read_gt_stats_snapshot(fd, eci, &stats_before);
> -- 
> 2.43.0
>