Re: [PATCH v6 1/4] lib: Add generic platform filtering framework

Hi Zhang,,
On 2026-08-20 at 02:03:00 +0000, Zhang, Jesse(Jie) wrote:
> AMD General
> 
> Review-by: Jesse Zhang <[email protected]>

One nit: it should be Reviewed-by:

so our tooling could work on patch.

Regards,
Kamil

> 
> > -----Original Message-----
> > From: [email protected] <[email protected]>
> > Sent: Thursday, August 20, 2026 9:27 AM
> > To: [email protected]
> > Cc: [email protected]; [email protected];
> > [email protected]; [email protected]; Zhang,
> > Jesse(Jie) <[email protected]>; Koenig, Christian
> > <[email protected]>; Deucher, Alexander
> > <[email protected]>; Prosyak, Vitaly <[email protected]>
> > Subject: [PATCH v6 1/4] lib: Add generic platform filtering framework
> >
> > From: Vitaly Prosyak <[email protected]>
> >
> > Implement vendor-agnostic platform filtering system that allows any vendor to plug
> > in platform-specific test skipping logic via callbacks.
> >
> > Key design elements:
> > - struct platform_filter_ops: vendor callback interface
> > - struct platform_skip_entry: vendor-neutral skip rule representation
> > - enum skip_source: three-tier priority (built-in, config, env)
> > - API functions: init, should_skip, require, dump
> >
> > Platform filtering is automatic - tests only need to call
> > platform_filter_init() once in igt_fixture. The IGT framework automatically checks
> > each subtest before execution via __igt_run_subtest().
> >
> > Cc: Kamil Konieczny <[email protected]>
> > Cc: Jani Nikula <[email protected]>
> > Cc: Krzysztof Karas <[email protected]>
> > Cc: Jesse Zhang <[email protected]>
> > Cc: Christian Koenig <[email protected]>
> > Cc: Alex Deucher <[email protected]>
> > Signed-off-by: Vitaly Prosyak <[email protected]>
> > Acked-by: Kamil Konieczny <[email protected]>
> > ---
> >  lib/igt_platform_filter.c | 575 ++++++++++++++++++++++++++++++++++++++
> >  lib/igt_platform_filter.h | 124 ++++++++
> >  lib/meson.build           |   1 +
> >  3 files changed, 700 insertions(+)
> >  create mode 100644 lib/igt_platform_filter.c  create mode 100644
> > lib/igt_platform_filter.h
> >
[cut]