Re: [PATCH] drm/i915/guc: Test GuC v70.74.0 for MTL, DG2

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The patch replaces the major-versioned GuC firmware definitions (`guc_maj`) with exact minor-patch versions (`guc_mmp`) for MTL and DG2, which removes the fallback logic and breaks GuC initialization on standard systems.
--

--- Patch [1]: [PATCH] drm/i915/guc: Test GuC v70.74.0 for MTL, DG2 ---
commit b7bd03e4f394bb57a559e10784e9ef6e098b9d4e
Author: Julia Filipchuk <[email protected]>

drm/i915/guc: Test GuC v70.74.0 for MTL, DG2

This patch updates the GuC firmware version to 70.74.0 for MTL and DG2 platforms.
It replaces the major-versioned definitions with exact minor-patch version definitions.

> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> index 7fac97fe30a63..4901cb9cb4ca6 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
[ ... ]
> @@ -88,8 +88,8 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
>   * security fixes, etc. to be enabled.
>   */
>  #define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_maj, guc_mmp) \
> -	fw_def(METEORLAKE,   0, guc_maj(mtl,  70, 53, 0)) \
> -	fw_def(DG2,          0, guc_maj(dg2,  70, 53, 0)) \
> +	fw_def(METEORLAKE,   0, guc_mmp(mtl,  70, 74, 0)) \
> +	fw_def(DG2,          0, guc_mmp(dg2,  70, 74, 0)) \

[Severity: High]
In INTEL_GUC_FIRMWARE_DEFS(), does removing the guc_maj fallback entry cause
a regression by breaking GuC initialization on systems where the exact firmware
version 70.74.0 is not present?

To test a new version while maintaining compatibility, should the guc_mmp
definition be added alongside (before) the guc_maj definition, rather than
replacing it?

>  	fw_def(ALDERLAKE_P,  0, guc_maj(adlp, 70, 12, 1)) \
>  	fw_def(ALDERLAKE_P,  0, guc_mmp(adlp, 70, 1, 1)) \

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1