✗ CI.checkpatch: warning for drm/i915/display: Enabl e AS SDP Skip Frames (rev3)
Patchwork <[email protected]> Wed, 05 Aug 2026 10:21:58 -0000
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <178592531804.21461.1063354767705331943@61270ab9df2a> |
== Series Details == Series: drm/i915/display: Enable AS SDP Skip Frames (rev3) URL : https://patchwork.freedesktop.org/series/162015/ State : warning == Summary == + KERNEL=/kernel + git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'... warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/ + git -C mt rev-list -n1 origin/master 061140b9bc586ae7f40abc1249c97e1cc72d1b9d + cd /kernel + git config --global --add safe.directory /kernel + git log -n1 commit 0ef50e0de27f0438fb05fd9b5014a2a8c42469bd Author: Uma Shankar <[email protected]> Date: Tue Aug 4 00:23:05 2026 +0530 drm/i915/display: Keep AS SDP flowing when skip frames is enabled The AS SDP skip-frame mechanism relies on the AS SDP still being transmitted (just less often) while Panel Replay is active, so the source must not stop sending it in the PR active state, nor enter the DC3CO idle protocol which would suppress it entirely. When a non-zero skip-frame count is programmed, leave both PR_ALPM_CTL_AS_SDP_TRANSMISSION_IN_ACTIVE_DISABLE and PR_ALPM_CTL_USE_DC3CO_IDLE_PROTOCOL cleared. The previous behaviour (honouring disable_as_sdp_when_pr_active and the DC3CO idle protocol) is retained for the non skip-frame case. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Naladala Ramanaidu <[email protected]> Signed-off-by: Uma Shankar <[email protected]> + /mt/dim checkpatch 4c13a67db118ee0019231dbc1362bcb8115ac660 drm-intel 7be27ce4e242 drm/i915/display: Enable AS SDP Skip Frames -:90: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #90: FILE: drivers/gpu/drm/i915/display/intel_alpm.c:455: + pr_alpm_ctl |= PR_ALPM_CTL_AS_SDP_SKIP_FRAMES( -:105: WARNING:LONG_LINE: line length of 125 exceeds 100 columns #105: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:280: +#define PR_ALPM_CTL_AS_SDP_SKIP_FRAMES(frames) REG_FIELD_PREP(PR_ALPM_CTL_AS_SDP_SKIP_FRAMES_MASK, (frames)) total: 0 errors, 1 warnings, 1 checks, 65 lines checked 0ef50e0de27f drm/i915/display: Keep AS SDP flowing when skip frames is enabled -:55: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #55: FILE: drivers/gpu/drm/i915/display/intel_alpm.c:462: + pr_alpm_ctl |= PR_ALPM_CTL_AS_SDP_TRANSMISSION_IN_ACTIVE_DISABLE; total: 0 errors, 1 warnings, 0 checks, 40 lines checked