Re: [PATCH v2 ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: remove obsolete firmware-name property
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.infradead.lists.ath11k,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 14/12/2025 03:52, Miaoqing Pan wrote: > The firmware-name property was introduced to allow end-users and > integrators to select usecase specific firmware for the WCN6855. > However, specifying firmware for an M.2 WLAN module in the Device > Tree is not appropriate. Instead, this functionality will be handled > within the ath11k driver. > > The driver has removed all support for firmware-name, and no upstream > Device Tree files reference this property. Therefore, this patch > removes the property from the binding and marks it as obsolete. No, it does not mark it obsolete. Point me to the place. > > This is a DT ABI-breaking change, but safe since there are no in-tree > users. It's not safe. What about my board using this WiFi? Or Mr. foo's board? Still NAK, you did not improve it. > > Acked-by: Rob Herring (Arm) <[email protected]> And that's a fake tag. Rob never acked such patch! Adding tags for something completely different is not acceptable. Nacked-by: Krzysztof Kozlowski <[email protected]> > Signed-off-by: Miaoqing Pan <[email protected]> > --- > .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > index e34d42a30192..653b319fee88 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > @@ -35,12 +35,6 @@ properties: > string to uniquely identify variant of the calibration data for designs > with colliding bus and device ids > > - firmware-name: > - maxItems: 1 > - description: > - If present, a board or platform specific string used to lookup > - usecase-specific firmware files for the device. > - > vddrfacmn-supply: > description: VDD_RFA_CMN supply regulator handle > Best regards, Krzysztof