Re: [PATCH v2 ath-current 1/2] wifi: ath11k: add usecase firmware handling based on device compatible
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.infradead.lists.ath11k,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 14/12/2025 03:52, Miaoqing Pan wrote: > For M.2 WLAN chips, there is no suitable DTS node to specify the > firmware-name property. In addition, assigning firmware for the > M.2 PCIe interface causes chips that do not use usecase specific > firmware to fail. Therefore, abandoning the approach of specifying > firmware in DTS. As an alternative, propose a static lookup table > mapping device compatible to firmware names. Currently, only WCN6855 > HW2.1 requires this. > > For details on usecase specific firmware, see: > https://lore.kernel.org/all/[email protected]/. > > Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1 > > Fixes: edbbc647c4f3 ("wifi: ath11k: support usercase-specific firmware overrides") > Reviewed-by: Baochen Qiang <[email protected]> > Signed-off-by: Miaoqing Pan <[email protected]> > --- I already said why it is wrong patch and you did not improve. You also added tags from reviews of something completely different, which effectively bypassed my filters. I find it unacceptable. Let me mark it formally: NAK Nacked-by: Krzysztof Kozlowski <[email protected]> Best regards, Krzysztof