Re: [PATCH v7 02/12] PCI: liveupdate: Track outgoing preserved PCI devices
Pasha Tatashin <[email protected]> Fri, 17 Jul 2026 19:38:18 +0000
| Newsgroups | org.infradead.lists.kexec,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kvack.linux-mm |
|---|---|
| Message-ID | <178431709881.189683.11618075685237566784.b4-review@b4> |
On Fri, 10 Jul 2026 21:26:05 +0000, David Matlack <[email protected]> wrote: > diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c > index 899758883dd5..03075ce06ac9 100644 > --- a/drivers/pci/liveupdate.c > +++ b/drivers/pci/liveupdate.c > @@ -125,6 +160,157 @@ static struct liveupdate_flb pci_liveupdate_flb = { > [ ... skip 18 lines ... ] > +static struct pci_dev_ser *pci_get_empty_or_append(struct pci_flb_outgoing *outgoing) > +{ > + struct pci_dev_ser *dev_ser, *found = NULL; > + struct kho_block_set_it it; > + int err; > + u32 count = 0; Nit, please move count above err, to follow reverse-christmas-tree order for declarations. Reviewed-by: Pasha Tatashin <[email protected]> -- Pasha Tatashin <[email protected]>