Re: [PATCH v7 01/12] PCI: liveupdate: Set up FLB handler for the PCI core

Pasha Tatashin <[email protected]> Fri, 17 Jul 2026 19:40:58 +0000

Newsgroups	org.infradead.lists.kexec,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kvack.linux-mm
Message-ID	<alqE_-OR-rB15Crx@plex>

On 07-17 16:30, Jason Gunthorpe wrote:
> On Fri, Jul 17, 2026 at 07:28:44PM +0000, Pasha Tatashin wrote:
> > On Fri, 10 Jul 2026 21:26:04 +0000, David Matlack <[email protected]> wrote:
> > > diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c
> > > new file mode 100644
> > > index 000000000000..899758883dd5
> > > --- /dev/null
> > > +++ b/drivers/pci/liveupdate.c
> > > @@ -0,0 +1,155 @@
> > > [ ... skip 50 lines ... ]
> > > +#include <linux/slab.h>
> > > +
> > > +/**
> > > + * struct pci_flb_outgoing - Outgoing PCI FLB object
> > > + * @ser: Pointer to the preserved struct pci_ser.
> > > + * @block_set: The KHO block set holding the outgoing devices.
> > 
> > AFAIK, these should be aligned after column:
> > @ser:       Pointer to ...
> > @block_set: The KHO block ...
> 
> Gosh I hope not, I never do that. The horizontal alignment is such a
> PITA to maintain.

Agreed. I just see that everywhere, so I thought it was the rule. If 
not, that is great; I hate them myself.

> 
> Jason