Re: [PATCH v2 3/4] arm64: dts: amlogic: meson-axg: Disable pcie_phy node by default

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The S400 board fails to enable the underlying `mipi_pcie_analog_dphy` required by `pcie_phy`, leaving PCIe broken and the deferred probe warning unresolved on this board.
--

commit 8447bc6097444b6a9914b09671ffb788547cd0fd
Author: Jun Yan <[email protected]>

arm64: dts: amlogic: meson-axg: Disable pcie_phy node by default
    
This commit disables the pcie_phy node by default in the meson-axg base
devicetree to suppress a deferred probe warning on boards that do not use it.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
[ ... ]
> @@ -328,6 +328,7 @@ pcie_phy: phy@ff644000 {
>  			phys = <&mipi_pcie_analog_dphy>;
>  			phy-names = "analog";
>  			#phy-cells = <0>;
> +			status = "disabled";
>  		};

[Severity: High]
This isn't a bug introduced by this patch, but does the S400 board fail to
enable the underlying mipi_pcie_analog_dphy required by pcie_phy?

Looking at arch/arm64/boot/dts/amlogic/meson-axg-s400.dts, the pcie_phy is
enabled:

&pcie_phy {
	status = "okay";
};

However, the analog PHY it depends on (mipi_pcie_analog_dphy) is disabled by
default in arch/arm64/boot/dts/amlogic/meson-axg.dtsi:

mipi_pcie_analog_dphy: phy {
	compatible = "amlogic,axg-mipi-pcie-analog-phy";
	#phy-cells = <0>;
	status = "disabled";
};

Since mipi_pcie_analog_dphy is never set to "okay" in the s400 board file,
won't pcie_phy continue to indefinitely defer its probe waiting for the
analog PHY, leaving PCIe broken on the S400 board?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic