Re: [PATCH v2 4/4] arm64: dts: amlogic: meson-axg-s400: Enable pcie_phy

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete feature enablement causing permanent probe deferral for PCIe functionality.
--

commit 202349024b583dc874155ce812fb658ddbab6228
Author: Jun Yan <[email protected]>

arm64: dts: amlogic: meson-axg-s400: Enable pcie_phy

This commit enables the pcie_phy node for the Amlogic meson-axg s400 board
device tree to support PCIe functionality.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 285c6ac1dd613..7ba249cc3d569 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -448,6 +448,10 @@ &pcieB {
>  	status = "okay";
>  };
>  
> +&pcie_phy {
> +	status = "okay";
> +};

[Severity: High]
This is a pre-existing issue, but does this incomplete enablement cause a
permanent probe deferral?

The amlogic,axg-pcie-phy driver unconditionally calls devm_phy_get(dev,
"analog") during probe. This maps to the mipi_pcie_analog_dphy node in
meson-axg.dtsi, which is set to disabled by default:

arch/arm64/boot/dts/amlogic/meson-axg.dtsi:
mipi_pcie_analog_dphy: phy {
	compatible = "amlogic,axg-mipi-pcie-analog-phy";
	#phy-cells = <0>;
	status = "disabled";
};

Since mipi_pcie_analog_dphy is not also overridden to "okay" here in
meson-axg-s400.dts, won't devm_phy_get() permanently return -EPROBE_DEFER,
preventing pcie_phy and the dependent pcieA/pcieB nodes from initializing?

> +
>  &pwm_ab {
>  	status = "okay";
>  	pinctrl-0 = <&pwm_a_x20_pins>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic