Re: [PATCH v2 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings
Xianwei Zhao <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
On 2026/8/20 14:49, Krzysztof Kozlowski wrote: > On 20/08/2026 08:38, Xianwei Zhao wrote: >> Hi Krzysztof, >> Thanks for your review. >> >> On 2026/8/13 16:28, Krzysztof Kozlowski wrote: >>> On Tue, Aug 11, 2026 at 08:37:43AM +0000, Xianwei Zhao wrote: >>>> Document the thermal controller compatibles for the Amlogic A9 SoC. >>>> >>>> Describe the required "core" and "plck" clocks, add the optional >>>> "amlogic,hw-reset-temp" property, and update the schema constraints for >>>> A9-specific thermal controllers. >>>> >>>> Signed-off-by: Xianwei Zhao<[email protected]> >>>> --- >>>> .../bindings/thermal/amlogic,thermal.yaml | 28 +++++++++++++++++++++- >>>> 1 file changed, 27 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml >>>> index 8cfa44dcda58..f73ee66bcc47 100644 >>>> --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml >>>> +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml >>>> @@ -23,6 +23,7 @@ properties: >>>> - const: amlogic,g12a-thermal >>>> - enum: >>>> - amlogic,a1-cpu-thermal >>>> + - amlogic,a9-thermal >>>> - amlogic,t7-thermal >>>> >>>> reg: >>>> @@ -32,7 +33,13 @@ properties: >>>> maxItems: 1 >>>> >>>> clocks: >>>> - maxItems: 1 >>>> + minItems: 1 >>>> + maxItems: 2 >>>> + >>>> + clock-names: >>>> + items: >>>> + - const: core >>>> + - const: pclk >>>> >>>> power-domains: >>>> maxItems: 1 >>>> @@ -52,6 +59,10 @@ properties: >>>> - description: phandle to the secure monitor >>>> - description: sensor index to get specific calibration data >>>> >>>> + amlogic,hw-reset-temp: >>>> + description: The hardware-controlled reset temperature value. >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> Thermal zones define that, not custom properties. >>> >> There are some differences here. The thermal zone goes through a >> software-controlled process and eventually triggers a restart or >> shutdown. There is some time between the temperature reaching the >> threshold and the actual restart or shutdown. In contrast, this > This feels like Linux problem, not binding? Fix Linux. > >> attribute configures a hardware-level protection mechanism that directly >> triggers a restart when the temperature reaches the configured threshold. >> >> If that's the case, do I also get it from Thermal zones? > > Thermal zones define your hardware temperature constraints, not custom > properties. > I will remove "amlogic,hw-reset-temp" property. > > Best regards, > Krzysztof _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic