Re: [PATCH v14 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Architecture / Layering Violation: Driver-specific header file is incorrectly placed in the global `include/linux/mfd/` directory.
--

--- Patch [4]: [PATCH v14 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator ---
commit 2a59167d38bc0c8607cf16c05249be2d7d9c9354
Author: Aman Kumar Pandey <[email protected]>

mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

This commit adds core MFD support for the NXP P3H2x4x family of multiport
I3C hub devices. These devices connect to a host via I3C/I2C/SMBus and
expose multiple downstream target ports.

[ ... ]

> diff --git a/include/linux/mfd/p3h2840.h b/include/linux/mfd/p3h2840.h
> new file mode 100644
> index 0000000000000..ba9a38756ecb8
> --- /dev/null
> +++ b/include/linux/mfd/p3h2840.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

[ ... ]

> +#define I3C_MANUF_ID_NXP					0x011b
> +
> +struct p3h2x4x {
> +	struct i3c_device *i3cdev;
> +	struct regmap *regmap;
> +	struct mutex protected_reg_lock; /* Serializes protected register unlock/lock sequences. */
> +};

[Severity: Low]
This isn't a bug, but since this header file defines driver-specific
structures solely intended for the parent and its immediate children, should
it be kept locally in drivers/mfd/ rather than being placed in the global
include/linux/mfd/ directory?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c