Re: [PATCH v14 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The driver-specific header `p3h2840.h` is improperly placed in the global `include/linux/mfd/` directory in violation of MFD subsystem guidelines.
--

--- Patch [5]: [PATCH v14 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub ---
commit dee1faf4c21dfa7f5c815bfdc8376ffa3158fbfe
Author: Aman Kumar Pandey <[email protected]>

regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub
    
The NXP P3H2x4x family integrates on-die regulators alongside I3C hub
functionality. This driver registers the regulators using the MFD
framework and exposes them via the regulator subsystem.

> diff --git a/drivers/regulator/p3h2840_i3c_hub_regulator.c b/drivers/regulator/p3h2840_i3c_hub_regulator.c
> new file mode 100644
> index 0000000000000..645d46ad7c2f2
> --- /dev/null
> +++ b/drivers/regulator/p3h2840_i3c_hub_regulator.c
> @@ -0,0 +1,284 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2025-2026 NXP
> + * NXP P3H2X4X regulator driver file contain functions for enable/disable regulator
> + * and voltage set/get.
> + */
> +#include <linux/bitfield.h>
> +#include <linux/cleanup.h>
> +#include <linux/mfd/p3h2840.h>

[Severity: Low]
According to the MFD subsystem guidelines, driver-specific header files that
are only used by the parent and its immediate children should not be placed
in the global include/linux/mfd/ directory.

Could p3h2840.h be kept local to drivers/mfd/ instead of being exposed in the
global include path?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c