Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Redundant definition of `vdda-refgen-supply` in the leaf board files `qcs9100-ride.dts` and `qcs9100-ride-r3.dts`.
--
--- Patch [4]: [PATCH v1 4/4] arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs ---
commit 95e45f63ab1216333770f51bde0f0be981ca36f9
Author: Ziyue Zhang <[email protected]>
arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs
The QMP PCIe PHYs on SA8775p require dedicated qref and refgen voltage
supplies for stable operation. This commit adds vdda-qref-supply and
vdda-refgen-supply in the board files to prevent occasional system crashes.
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> index 40f88498999bd..8dc4a5f461e9e 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> @@ -983,6 +983,8 @@ &pcie1 {
> &pcie0_phy {
> vdda-phy-supply = <&vreg_l5a>;
> vdda-pll-supply = <&vreg_l1c>;
> + vdda-qref-supply = <&vreg_l4a>;
> + vdda-refgen-supply = <&vreg_l7a>;
>
> status = "okay";
> };
> @@ -990,6 +992,8 @@ &pcie0_phy {
> &pcie1_phy {
> vdda-phy-supply = <&vreg_l5a>;
> vdda-pll-supply = <&vreg_l1c>;
> + vdda-qref-supply = <&vreg_l4a>;
> + vdda-refgen-supply = <&vreg_l7a>;
>
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> index 7fc2de0d3d5e2..1b6a4f9cb8f7e 100644
> --- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> @@ -14,3 +14,11 @@ / {
> model = "Qualcomm Technologies, Inc. Lemans Ride Rev3";
> compatible = "qcom,qcs9100-ride-r3", "qcom,qcs9100", "qcom,sa8775p";
> };
> +
> +&pcie0_phy {
> + vdda-refgen-supply = <&vreg_l7a>;
> +};
> +
> +&pcie1_phy {
> + vdda-refgen-supply = <&vreg_l7a>;
> +};
[Severity: Low]
This isn't a bug, but are these vdda-refgen-supply assignments necessary in
the leaf board files?
Since lemans-ride-common.dtsi already adds these exact same vreg_l7a
assignments for both pcie0_phy and pcie1_phy, redefining them in
qcs9100-ride-r3.dts seems redundant.
> diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
> index b0c5fdde56aea..cc15025fdbc1a 100644
> --- a/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
> @@ -14,3 +14,11 @@ / {
> model = "Qualcomm Technologies, Inc. Lemans Ride";
> compatible = "qcom,qcs9100-ride", "qcom,qcs9100", "qcom,sa8775p";
> };
> +
> +&pcie0_phy {
> + vdda-refgen-supply = <&vreg_l7a>;
> +};
> +
> +&pcie1_phy {
> + vdda-refgen-supply = <&vreg_l7a>;
> +};
[Severity: Low]
This isn't a bug, but similarly here, does qcs9100-ride.dts need to duplicate
the vdda-refgen-supply assignments that are already inherited from
lemans-ride-common.dtsi?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
--
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.