Re: [PATCH v1 3/4] arm64: dts: qcom: qcs8300: Add qref and refgen supply for PCIe PHYs

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The newly added DTS regulator properties for QCS8300 are silently ignored by the PCIe PHY driver, while the SM8450 driver now erroneously requires them, causing a severe probe regression.
--

--- Patch [3]: [PATCH v1 3/4] arm64: dts: qcom: qcs8300: Add qref and refgen supply for PCIe PHYs ---
commit 649091d8c2c2002b7f51183d74007a50f755b8db
Author: Ziyue Zhang <[email protected]>

arm64: dts: qcom: qcs8300: Add qref and refgen supply for PCIe PHYs
    
This commit adds vdda-qref-supply, vdda-refgen-supply, and refgen-supply to
various QCS8300 board and SoC device trees. These dedicated voltage supplies
are required by the QMP PCIe PHYs to prevent occasional system crashes.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 9d17ef7d2caf1..c1f63a4ee2438 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -623,6 +623,8 @@ &pcie0 {
>  &pcie0_phy {
>  	vdda-phy-supply = <&vreg_l6a>;
>  	vdda-pll-supply = <&vreg_l5a>;
> +	vdda-qref-supply = <&vreg_l4a>;
> +	vdda-refgen-supply = <&vreg_l7a>;

[Severity: High]
Will these new supplies actually be consumed by the QCS8300 PHY driver?

Looking at the driver changes presumably earlier in this series, it appears
the updated regulator list was mistakenly applied to the sm8450 configuration
instead of the qcs8300 configuration:

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c:qcs8300_qmp_gen4x2_pciephy_cfg() {
    ...
    .vreg_list      = qmp_phy_vreg_l,
    .num_vregs      = ARRAY_SIZE(qmp_phy_vreg_l),
}

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c:sm8450_qmp_gen4x2_pciephy_cfg() {
    ...
    .vreg_list      = sa8775p_qmp_phy_vreg_l,
    .num_vregs      = ARRAY_SIZE(sa8775p_qmp_phy_vreg_l),
}

Does this mean the driver will still ignore these newly added properties on
QCS8300, while causing a probe regression on SM8450 platforms due to the
missing regulators?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3

-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy