Re: [PATCH 1/7] media: verisilicon: Fix the cleanup when a codec ->run() fails
Nicolas Dufresne <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Organization | Collabora Canada |
| Message-ID | <[email protected]> |
Hi Sascha,
Le mercredi 19 août 2026 à 12:37 +0200, Sascha Hauer a écrit :
> ret = start_prepare_run(ctx, &decode_params);
> if (ret) {
> - hantro_end_prepare_run(ctx);
> + hantro_end_prepare_run(ctx, ret);
Since its already in an if (ret) branch, and for code readability, can you use
hantro_abort_prepare_run(ctx) instead and leave all other sucessful calls as-is.
Nicolas
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaoXGPwAKCRDZQZRRKWBy 9J96AP4pVbuljONCTasFDnqGz3LRJHuAwLr5VErmMrO2wrsqrwEAzhFgMDQ9TSeS /dfy+t87UYjwpZwgjpWq+Cp2ewMU1wo= =KCQs -----END PGP SIGNATURE-----