Re: [PATCH] lib: utils: Fix LLVM compile error in MPXY client driver for RPMI MM

Ranbir Singh <[email protected]>
Newsgroups org.infradead.lists.opensbi
Message-ID <CAPPZMLFPwL13s09YivtRz7pMhDk5fRvrdZ63XaUqwiJ4aQKkOg@mail.gmail.com>
On Sat, May 9, 2026 at 9:55 PM Anup Patel <[email protected]> wrote:
>
> The following compile error is seen with LLVM compiler:
>
>  CC        platform/generic/lib/utils/mpxy/fdt_mpxy_rpmi_mm.o
> lib/utils/mpxy/fdt_mpxy_rpmi_mm.c:17:6: error: use of GNU 'missing =' extension in
>       designator [-Werror,-Wgnu-designator]
>    17 |         [0] {
>       |             ^
>       |             =
> lib/utils/mpxy/fdt_mpxy_rpmi_mm.c:24:6: error: use of GNU 'missing =' extension in
>       designator [-Werror,-Wgnu-designator]
>    24 |         [1] {
>       |             ^
>       |             =
> 2 errors generated.
>
> Add missing "=" in mm_srvcdata[] array initialization to address
> the above issue.
>
> Fixes: 0b041e58c078 ("lib: utils: Add MPXY client driver for RPMI MM service group")
> Signed-off-by: Anup Patel <[email protected]>

LGTM

Reviewed-by: Ranbir Singh <[email protected]>


> ---
>  lib/utils/mpxy/fdt_mpxy_rpmi_mm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/utils/mpxy/fdt_mpxy_rpmi_mm.c b/lib/utils/mpxy/fdt_mpxy_rpmi_mm.c
> index 0163d0d2..d7176aca 100644
> --- a/lib/utils/mpxy/fdt_mpxy_rpmi_mm.c
> +++ b/lib/utils/mpxy/fdt_mpxy_rpmi_mm.c
> @@ -14,14 +14,14 @@
>  static struct rpmi_mm_get_attributes_rsp rsp;
>
>  static struct mpxy_rpmi_service_data mm_srvcdata[] = {
> -       [0] {
> +       [0] = {
>                 .id = RPMI_MM_SRV_GET_ATTRIBUTES,
>                 .min_tx_len = 0,
>                 .max_tx_len = 0,
>                 .min_rx_len = sizeof(struct rpmi_mm_get_attributes_rsp),
>                 .max_rx_len = sizeof(struct rpmi_mm_get_attributes_rsp),
>         },
> -       [1] {
> +       [1] = {
>                 .id = RPMI_MM_SRV_COMMUNICATE,
>                 .min_tx_len = sizeof(struct rpmi_mm_communicate_req),
>                 .max_tx_len = sizeof(struct rpmi_mm_communicate_req),
> --
> 2.43.0
>
>
> --
> opensbi mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/opensbi

-- 
opensbi mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/opensbi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.