Re: b4 review state is broken after series reorders patches?

On Mon, 06 Apr 2026 10:23:17 -0400, Tamir Duberstein wrote:
> Hi Konstantin,
> 
> I reviewed v1 of
> https://lore.kernel.org/all/[email protected]/,
> but I was then unable to review v2; range diff failed with `Could not
> find series v2 in retrieved messages`. After some hacking with Codex I
> got this working. However, after reviewing v2 (which only required
> replies for three patches), the send email dialog offered to send all
> 30 review emails again.

Thanks for testing that -- what we're doing with v1 reviews on upgrade 
to v2 clearly needs some more thought, because it was written to deal 
with the following scenario:

- Maintainer writes reviews for v1
- Sender provides v2 before maintainer completes their review
- Maintainer upgrades to v2 and we carry forward all reviews for 
  identical patches so they are not lost

However, your scenario is different:

- Maintainer writes reviews for v1 and sends them
- Sender provides v2 in response to feedback
- Maintainer upgrades to v2 and we carry forward all previous reviews 
  (but they were already sent, so may or may not be relevant for v2)

Let me see if we can improve what happens in this scenario.

Tracking as bug cacfeb7.

-K