Re: b4 review state is broken after series reorders patches?

Konstantin Ryabitsev <[email protected]>
Newsgroups org.kernel.linux.tools
Message-ID <177550045089.3385816.4021244769990222254.b4-reply@b4>
On Mon, 06 Apr 2026 13:59:31 -0400, Konstantin Ryabitsev wrote:
> - Maintainer writes reviews for v1 and sends them
> - Sender provides v2 in response to feedback
> - Maintainer upgrades to v2 and we carry forward all previous reviews 
>   (but they were already sent, so may or may not be relevant for v2)
> 
> Let me see if we can improve what happens in this scenario.

There is an attempted fix in master. We're now marking comments that 
were sent with sent-revision and will do two things on series upgrade:

- not carry them forward to identical patches from vN to vN+1
- will automatically mark identical patches as "skip" on upgrade, so you 
  should only see patches that have changed

This won't work retroactively, but should kick in next time you send a 
reply to a series.

There are probably still lots of buggy corner-cases with reviews and 
upgrades, so please keep sending the reports in as you discover them.

Best wishes,
-- 
KR
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.