Re: [PATCH b4] review: allow a custom Message-Id command for TUI replies

On Fri, May 22, 2026 at 12:57:56PM +0200, Christian Brauner wrote:
> The review TUI composes replies and sends them directly over SMTP via
> send_mail(), bypassing git-send-email and therefore any sendemail-validate
> hook that would normally rewrite the Message-Id. Review replies thus always
> got a built-in <...@b4> id.
> 
> Add an opt-in b4.review-msgid-cmd option: when set, run it and use its
> stdout as the Message-Id (angle brackets optional), falling back to the
> built-in id when unset or on failure. Wire it into both the review-reply
> builder and LoreMessage.make_reply() so follow-up replies are covered too.
> 
> Signed-off-by: Christian Brauner (Amutable) <[email protected]>
> ---
> I love b4 review and I'm in the process of making it my default review
> tool. 2026 and kernel review is officially better than Github. Didn't
> expect to see that day tbh.

Oh, amazing, thank you so much for saying that. :) I'm not sure I'd go as far
as being better than GH -- there are still lots of sharp edges, but I'm glad
it's starting to shape up a little.

> All my reviews come with specific message ids and I would like to be
> able to continue using them so I would appreciate the ability to define
> a message-id generation command in the [b4] .gitconfig section.

This patch won't quite cover every possible case -- e.g. it will miss the
thank-you notes that are still sent with the same code path as "b4 ty". Let
me think of a more global way to plug this in that won't clash with
message-id's that are generated for series with "b4 prep/send".

Thanks,
-K