Re: [PATCH b4] review: allow a custom Message-Id command for TUI replies

Konstantin Ryabitsev <[email protected]> Tue, 9 Jun 2026 21:47:39 -0400
Newsgroups org.kernel.linux.tools
Message-ID <20260609-terrestrial-military-honeybee-d6ffcc@meerkat>
On Tue, Jun 09, 2026 at 09:11:01PM -0400, Konstantin Ryabitsev wrote:
> This patch won't quite cover every possible case -- e.g. it will miss the
> thank-you notes that are still sent with the same code path as "b4 ty". Let
> me think of a more global way to plug this in that won't clash with
> message-id's that are generated for series with "b4 prep/send".

Rather than adding a parallel make_msgid_with_cmd() helper, I folded the
hook directly into make_msgid() behind an allow_custom_msgid_cmd flag,
and flipped that flag on at exactly the reply/notification call sites:
review replies, follow-up replies, and ty notes. When the flag is set
and b4.custom-msgid-cmd is configured, b4 runs the command and uses its
stdout as the Message-Id (angle brackets optional), falling back to the
built-in <...@b4> id when the option is unset, produces no output, or
fails.

I renamed the option to b4.custom-msgid-cmd (dropping the "review-"
prefix) since it now reaches beyond the review TUI.

Try it out and let me know if that's what you were looking for.

Thanks,
-K