[MODERATED] Re: Re: [PATCH 2/2] more sampling fun 2

On Mon, Feb 24, 2020 at 07:17:34PM +0100, speck for Borislav Petkov wrote:
> On Mon, Feb 24, 2020 at 12:31:21PM -0500, speck for Konrad Rzeszutek Wilk wrote:
> > > This patch:
> > > * enables administrator to configure the mitigation off when desired
> > >   using either mitigations=off or srbds=off.
> > > * exports vulnerability status via sysfs
> > 
> > I think you also need a Documentation patch, that is a new file in
> > Documentation/x86/srbds.rst
> > and changes in 
> > Documentation/admin-guide/kernel-parameters.txt
> > 
> > to document the srbds=..
> 
> That "srbds" string better be something more human-readable like
> 
> "srb_sampling="

The implementation uses srbds_mitigation=..  (the commit comment now updated to
reflect this)

I've been holding on getting the finished white paper to be sure both documents
are are in sync.

--mark

> 
> or so.
> 
> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
> --