[MODERATED] Re: [PATCH 1/2] more sampling fun 1

Ben Hutchings <[email protected]> Thu, 20 Feb 2020 19:08:45 +0000

Newsgroups	org.kernel.lore.historical-speck
Message-ID	<[email protected]>

On Thu, 2020-02-06 at 14:11 -0800, speck for mark gross wrote:
> From: mark gross <[email protected]>
> Subject: [PATCH 1/2] Add capability to specify a range of steppings in the
[...]
> --- a/arch/x86/include/asm/cpu_device_id.h
> +++ b/arch/x86/include/asm/cpu_device_id.h
> @@ -35,7 +35,19 @@ struct x86_cpu_desc {
>  	.x86_microcode_rev	= (revision),			\
>  }
>  
> +/*
> + * Match a range of steppings
> + */
> +
> +struct x86_cpu_id_ext {
> +	struct x86_cpu_id id;
> +	__u16 steppings; /* bit map of steppings to match against */
> +};
> +
> +#define X86_STEPPING_ANY 0
[...]

Minor point, but wouldn't it make more sense to define X86_STEPPING_ANY
as GENMASK(15, 0)?  Then it's no longer a special case.

Ben.

-- 
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.

signature.asc (application/pgp-signature, 833 B)