Re: [PATCH v6 net-next 1/1] tcp: Replace min_tso_segs() with tso_segs() CC callback

Paolo Abeni <[email protected]> Tue, 4 Aug 2026 16:08:39 +0200
Newsgroups org.kernel.vger.bpf,org.kernel.vger.linux-kselftest,org.kernel.vger.netdev
Message-ID <[email protected]>
On 7/30/26 1:49 PM, [email protected] wrote:
> From: Chia-Yu Chang <[email protected]>
> 
> This patch replaces existing min_tso_segs() with tso_segs() CC callback
> for CC algorithm to provide explicit tso segment number of each data
> burst and overrides tcp_tso_autosize().
> 
> This change provides below impacts on BPF struct_ops users:
> - The callback is renamed from min_tso_segs() to tso_segs()
> - The signature gains an extra u32 mss_now argument
> - The return value semantics is changed from "floor value passed into
>   tcp_tso_autosize()" to "final tso_segs value", bypassing autosizing
> 
> As a result, BPF programs shall be updated, because returning a small
> constant will now directly limit the final tso_segs value instead of
> specifying the minimum value passed to tcp_tso_autosize().
> 
> Signed-off-by: Ilpo Järvinen <[email protected]>
> Signed-off-by: Chia-Yu Chang <[email protected]>
> Reviewed-by: Emil Tsalapatis <[email protected]>
Sashiko nipa has more feedback, that looks relevant to me even if it's
tagged not hi prio:

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260730114919.658373-1-chia-yu.chang%40nokia-bell-labs.com

/P