Re: [PATCH bpf-next v8 3/6] bpf: Show more useful info in stack depth stats

> Stack depth statistics list captured depths in subprogram-number order,
> while per-verification instruction counts are reported separately. Since
> libbpf determines subprogram numbers, it is hard to associate either
> statistic with its subprogram name or see where verifier work is spent.
>
> Now that self and inclusive instruction counts are available for every
> subprogram, keep the combined maximum stack depth on its own line and print
> one uniform record for each subprogram. Represent the main program as
> subprog 0, then classify each record as main, global, or static before
> reporting insns_self, insns_total, and stack depth.
>
> The aggregate processed count is the sum of all self counts, while each
> total shows verifier work rooted at that subprogram.
>
> When no subprogram name is available, print <unknown>. Keep the existing
> aggregate "processed ... insns" record unchanged for compatibility.

This isn't a bug, but does the middle paragraph add information beyond what
the diff shows? It walks through the implementation (keep the max on its own
line, represent main as subprog 0, classify each record), which is visible
in the code. Would it help to show the new log format verbatim instead -
perhaps one example record - and note which consumers had to change for the
format update?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31647029137