Re: [PATCH bpf-next v8 5/6] selftests/bpf: Test stack depth stats without BTF subprog names

> Test the per-program insns_self, insns_total, and stack depth statistics
> emitted when BTF function info does not provide subprogram names. Check that
> the subprog 0 main record and static-subprogram records use <unknown>.
>
> Make VERBOSE_ACCEPT request verifier statistics so the raw-insn test can
> validate the output without a test-specific log level.
>
> Acked-by: Eduard Zingerman <[email protected]>
> Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]>

This isn't a bug, but since the expected log splits around the
insns_self/insns_total values, would it read more accurately to say this
checks the record format (names, kind, stack depths) rather than the
instruction statistics themselves?

Looking at the test's expected string:

    .errstr = "stack depth max 352\t"
              "subprog 0 (<unknown>) main insns_self \t"
              " insns_total \t"
              " stack 32\t"

The cmp_str_seq() matching only verifies the label text exists, not the actual
counts. What gets pinned is the record layout, the subprog ordering, the
'<unknown>' names, the main/static classification and the stack depths (32,
256, 64, max 352), but not the instruction counts themselves.


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31647029137