Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock
Richard Sailer <[email protected]>
| Newsgroups | org.kernel.vger.dccp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo <[email protected]> > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > del_timer_sync can't be used is because this relies on keeping a reference > to struct sock. But as we keep a pointer to dccps_hc_tx_ccid and free that > during disconnect, the timer should really belong to struct dccp_sock. > > This addresses CVE-2020-16119. > > Fixes: 839a6094140a (net: dccp: Convert timers to use timer_setup()) > Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]> > Signed-off-by: Kleber Sacilotto de Souza <[email protected]> Acked-bd: Richard Sailer <[email protected]> Implementation and concept looks fine to me
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEBgAhuYrOnl9UC7I39kE5zAWb4eEFAl+F+N8ACgkQ9kE5zAWb 4eH0WQf/UWTTCBzTGhg11Zme2bEngbGDoD/xYPUZ8TvPD7cXCoq0WGSVG9yqaTc1 vXwH1+jvNoJHQ7NvXOoUEe1fGmgNVdFNIw5RzEy/9Oi8rukTpvjloFCproonNeNs mVAS95hbRHKho+NG+MmtR3yuH52SLtgtCdn64lJjAaNeX1oWGbUNwSK7TNY9Wrjj ubteuQz3mFOFyca/V4xJZU58jz5Ikp420w/UdQGGtmUf133L3rZxDrT0ilKkZEiS eeDfKRDQlkBbCvOlkuG6dER/nPUF0in8n1Ci6Jycwk2gsMIKSt3La178e3di6NHB zdVms9QK+dASFjYym7NaXmjTjXS+cQ== =WF3A -----END PGP SIGNATURE-----